fix: inject NEXT_PUBLIC_FUNKIT_API_KEY in CI builds; guard FunkitCheckout against a missing key#3018
Merged
sammdec merged 2 commits intoJun 16, 2026
Conversation
…kout against a missing key The funkit checkout host is mounted globally in _app, and FunkitProvider's validateFunkitConfig throws 'Invalid funkitConfig: Missing apiKey.' on an empty apiKey. The CI build pipeline never injected NEXT_PUBLIC_FUNKIT_API_KEY, so every cypress smoke build crashed the whole app on load (all markets) — the dashboard toggle and supply modal never rendered. - Inject NEXT_PUBLIC_FUNKIT_API_KEY (from the new FUNKIT_API_KEY repo secret) through the build composite action and every workflow that builds the app (build-test-deploy, build-test-deploy-dev, build-fork, build_staging). - Guard FunkitCheckout: render null when funkitConfig.apiKey is empty, so a missing/misconfigured key can never white-screen the app again — Supply falls back to the native modal via the existing beginFunSupply()->false path. - Revert the temporary DebugCrashBoundary (aave#3017) used to pinpoint this. Requires the FUNKIT_API_KEY secret to be added to the repo for funkit to be functional (publishable client-side key); without it the app degrades to native supply rather than crashing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@yogurtandjam is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
yogurtandjam
commented
Jun 15, 2026
build-fork only produces the out_cypress artifact for the fork-cypress flow (test-deploy-fork.yml); it is never deployed to users, and the FunkitCheckout apiKey guard already prevents a crash when the key is absent. The key is only needed in jobs that deploy a human-facing build (build-test-deploy[/dev]). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The funkit checkout host is mounted globally in _app, and FunkitProvider's validateFunkitConfig throws 'Invalid funkitConfig: Missing apiKey.' on an empty apiKey. The CI build pipeline never injected NEXT_PUBLIC_FUNKIT_API_KEY, so every cypress smoke build crashed the whole app on load (all markets) — the dashboard toggle and supply modal never rendered.
Requires the FUNKIT_API_KEY secret to be added to the repo for funkit to be functional (publishable client-side key); without it the app degrades to native supply rather than crashing.